make update_full_account_codes trigger more effective

adamcharnock / django-hordak

Double entry accounting in Django

http://django-hordak.readthedocs.io

MIT License

254 stars 58 forks source link

make update_full_account_codes trigger more effective #49

Closed PetrDlouhy closed 4 years ago

PetrDlouhy commented 4 years ago

I have large number of Hordak accounts in my system (account for every user of our system). Most in our system accounts doesn't have any code associated. I have problems with long running triggers (~4 sec) after Hordak account update

This changes the update_full_account_codes so that it doesn't include records with Null codes these records do not affect the result of update command.

coveralls commented 4 years ago

Coverage remained the same at 95.488% when pulling 23ce58dbb626c9792eb539096518838cf5c079fd on PetrDlouhy:fix/effective_triggers into 90e31c6d1c1870efdfdb367df3f3c5f048913e02 on adamcharnock:master.

adamcharnock commented 4 years ago

Looks great to me, thank you @PetrDlouhy, merged!

adamcharnock commented 4 years ago

Released in 1.10.0, which also drops support for Python 3.5 and includes #38