search

adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
231 stars 55 forks source link

Preparation for django 4 #54

Closed nshayanfar closed 2 years ago

nshayanfar commented 3 years ago

Hi @adamcharnock ,

In the current state of hordak there are some issues that raise a warning when called by runserver command. These are mainly, compatibility issues which have occurred with newer versions of django. Are you open to the idea of some updating? what i have in mind are these two at the moment.

1- conversion of postgres.fields.jsonfield to models.jsonfield 2- providing multilingual translation through get_lazy for model names and errors

adamcharnock commented 3 years ago

Hi Nima!

I’m very open to this, and it would be a big help. Send a pull request and I’ll happy review and merge as long as the tests are happy.

On 2 Jan 2021, at 16:02, Nima Shayanfar notifications@github.com wrote:

Hi @adamcharnock https://github.com/adamcharnock ,

In the current state of hordak there are some issues that raise a warning when called by runserver command. These are mainly, compatibility issues which have occurred with newer versions of django. Are you open to the idea of some updating? what i have in mind are these two at the moment.

1- conversion of postgres.fields.jsonfield to models.jsonfield 2- providing multilingual translation through get_lazy for model names and errors

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamcharnock/django-hordak/issues/54, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABBXZ7PPIKDGUN2PJVUT23SX47SNANCNFSM4VREZDPQ.

PetrDlouhy commented 2 years ago

@adamcharnock There are MRs #60 and #61 with at least the JSONFiled fix. The tests didn't run I suspect, that is because of that Travis screwed open-source testing and the tests will need to be transformed to GitHub actions.

I can try to help - at least with the GitHub actions. What do you think?

adamcharnock commented 2 years ago

Hi @PetrDlouhy! If you can help with the github actions that would be fantastic. I'm pretty preoccupied with paid work at the moment, but if you need any further permissions/access just let me know.

PetrDlouhy commented 2 years ago

Django 4.0 support is now in the new release 1.10.1.