search

adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
254 stars 58 forks source link

class AccountTransactionsView(LoginRequiredMixin, SingleObjectMixin, View): ->class AccountTransactionsView(LoginRequiredMixin, SingleObjectMixin, ListView): #64

Closed paeduardo closed 2 years ago

paeduardo commented 2 years ago

Hi! after migrating from django-hordak==1.10.0 to django-hordak==1.10.1 there is error when trying to view account transactions: 'super' object has no attribute 'get' /usr/local/lib/python3.9/site-packages/hordak/views/accounts.py, line 89, in get return super(AccountTransactionsView, self).get(request, *args, **kwargs)

Please verify if instead of View in class AccountTransactionsView(LoginRequiredMixin, SingleObjectMixin, View): should be ListView, i.e.: class AccountTransactionsView(LoginRequiredMixin, SingleObjectMixin, ListView): like it was in previous version. Best regards, Pawel

PetrDlouhy commented 2 years ago

@paeduardo Thank you for the report. I introduced the bug when I tried to fix mypy report that was generated on base of this error: https://github.com/typeddjango/django-stubs/issues/873 There were also no tests for this view. I fixed this, added tests and released new version 1.10.2.

paeduardo commented 2 years ago

@PetrDlouhy Thank you for immediate response, fix and release!!!