adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
228 stars 55 forks source link

Updating precommit and gitignore #84

Closed nitsujri closed 1 year ago

nitsujri commented 1 year ago

Not sure if this repo is open to using pytest instead of unittest as the test runner, but in VSCode pytest is the defacto way to run specs from within the environment.

Ignoring poetry unless we're interested in switching from pip.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (0a677fe) 92.43% compared to head (e5c1b2b) 92.43%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #84 +/- ## ======================================= Coverage 92.43% 92.43% ======================================= Files 57 57 Lines 3502 3502 Branches 223 223 ======================================= Hits 3237 3237 Misses 223 223 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

PetrDlouhy commented 1 year ago

Seems reasonable.

I don't know what changes would introducing pytest need, but if it is only the pytest.ini and other developers would benefit from it I would not be against including it in the repo.