Could we include 0038_alter_account_id_alter_leg_id_and_more.py in the package

[kumarnmanoj]

Running makemigrations after adding hordak to the django project creates the mentioned migration

(django-workshop-py3.10) ➜  django_workshop python manage.py makemigrations
Migrations for 'hordak':
  .venv/lib/python3.10/site-packages/hordak/migrations/0038_alter_account_id_alter_leg_id_and_more.py
    - Alter field id on account
    - Alter field id on leg
    - Alter field id on statementimport
    - Alter field id on statementline
    - Alter field id on transaction
    - Alter field id on transactioncsvimport
    - Alter field id on transactioncsvimportcolumn

Installed version details

python = "^3.10"
django = "^4.2.3"
psycopg2 = "^2.9.6"
django-hordak = {extras = ["subqueries"], version = "^1.14.0"}

In the settings.py we have

HORDAK_DECIMAL_PLACES = 5
HORDAK_MAX_DIGITS = 13

[kumarnmanoj]

@adamcharnock Any help here would be appreciated. hordack fits to our requirement we are planning to use this

[adamcharnock]

Hi @kumarnmanoj, I have just taken a look at this (on Django 4.2) and run makemigrations myself. No migrations were created, so things seem ok on my side.

The migrations you are seeing only seem to affect the id field, so I am wondering if this issue relates your project's configuration of DEFAULT_AUTO_FIELD.

I haven't worked on this project for a little while, @PetrDlouhy has been much more involved than I of late.

[PetrDlouhy]

We could probably set AppConfig.default_auto_field (https://docs.djangoproject.com/en/4.2/ref/applications/#django.apps.AppConfig.default_auto_field) for django-hordak project explicitly and make the migration.

@kumarnmanoj Do you volunteer to make an PR with that?

[Lekhanshlkr]

@PetrDlouhy I've raised a PR for it. (https://github.com/adamcharnock/django-hordak/pull/99) Please let me know if any changes required. Thanks! cc @adamcharnock @kumarnmanoj

[kumarnmanoj]

Thank you @Lekhanshlkr

[adamcharnock]

Closed by #112 (based on #99)