search

adamchester / expecto-adapter

Visual Studio test adapter for Expecto (https://github.com/haf/expecto)
MIT License
28 stars 16 forks source link

Support for Newtonsoft.Json 11 & 12 #46

Closed trbarrett closed 5 years ago

trbarrett commented 5 years ago 
Error Unable to resolve dependencies. 'Newtonsoft.Json 11.0.2' is not compatible with 'Expecto.VisualStudio.TestAdapter 10.0.1 constraint: Newtonsoft.Json (>= 10.0.0 && < 11.0.0)'.

Hi, would it be possible to add support for more recent versions of Newtonsoft.Json to the nuget dependencies? 11.X, which came out last February, and perhaps the more recent 12.X?

https://github.com/adamchester/expecto-adapter/blob/master/nuspec/Expecto.VisualStudio.TestAdapter.nuspec#L22

https://github.com/JamesNK/Newtonsoft.Json/releases

Cheers

jackfoxy commented 5 years ago

Expecto.VisualStudio.TestAdapter 10.0.1, which requested package Newtonsoft.Json: >= 10.0 < 11.0 Fake.DotNet.Cli 5.0.0 requested package Newtonsoft.Json: >= 11.0.2 causing Fake to downgrade Expecto

MNie commented 5 years ago

I will try to update it during a weekend.

MNie commented 5 years ago

@adamchester could you push it to nuget since my apikey expired, please :)?

adamchester commented 5 years ago

@MNie sent you the code ;)

MNie commented 5 years ago

@jackfoxy, @trbarrett pushed a new version.

jackfoxy commented 5 years ago

I just tested. Everything looks good. Thanks, @MNie