Some improvements to nanovega

adamdruppe / arsd

This is a collection of modules that I've released over the years. Most of them stand alone, or have just one or two dependencies in here, so you don't have to download this whole repo.

http://arsd-official.dpldocs.info/arsd.html

531 stars 128 forks source link

Some improvements to nanovega #200

Closed AsumFace closed 5 years ago

AsumFace commented 5 years ago

Support for external OpenGL and FreeType bindings
Modernization of OpenGL calls
Change of behavior of the mipmapping option (existing code may render differently with this change)
Addition of a LOD bias for better render quality of textures

adamdruppe commented 5 years ago

Interesting, I'll have to test in a few of my use cases before I merge just to make sure nothing inadvertently broke, but from a quick glance it all looks right!

I should have time to test tomorrow night, so I'll get back to you then. Thanks for the PR!

0xEAB commented 5 years ago

Change of behavior of the mipmapping option (existing code may render differently with this change)

Any example what's going to break?

AsumFace commented 5 years ago

Any example what's going to break?

Any code that sets both NoFiltering and GenerateMipmaps for images may experience a slight visual change and a memory usage increase (due to the generated mipmap). Since GenerateMipmaps is currently ineffective when NoFiltering is set, this combination is probably not used anywhere intentionally.

adamdruppe commented 5 years ago

well, it continued to work normally on my low-dependency test, so merged in!

0xEAB commented 5 years ago

Any code that sets both NoFiltering and GenerateMipmaps...

Thanks for clarifying :)