search

adamdruppe / arsd

This is a collection of modules that I've released over the years. Most of them stand alone, or have just one or two dependencies in here, so you don't have to download this whole repo.
http://arsd-official.dpldocs.info/arsd.html
530 stars 127 forks source link

Does it need to call ChoosePixelFormat twice? #253

Closed johnburton closed 4 years ago

johnburton commented 4 years ago

Very minor issue, if it is in fact one at all, and only detail rather than a bug but is there any reason why simpledisplay calls ChoosePixelFormat in line 8402 when it just got the value in line 8400?

https://github.com/adamdruppe/arsd/blob/master/simpledisplay.d#L8400

adamdruppe commented 4 years ago

I probably copy/pasted the line at some point doing error checking and just mindlessly messed it up.....

On Wed, May 13, 2020 at 11:35:42PM -0700, John Burton wrote:

Very minor issue, if it is in fact one at all, and only detail rather than a bug but is there any reason why simpledisplay calls ChoosePixelFormat in line 8402 when it just got the value in line 8400?

https://github.com/adamdruppe/arsd/blob/master/simpledisplay.d#L8400

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/adamdruppe/arsd/issues/253

adamdruppe commented 4 years ago

there removed and nothing broke!