search

adamdruppe / arsd

This is a collection of modules that I've released over the years. Most of them stand alone, or have just one or two dependencies in here, so you don't have to download this whole repo.
http://arsd-official.dpldocs.info/arsd.html
531 stars 128 forks source link

Fix unreachable statement #254

Closed NotMichaelChen closed 4 years ago

NotMichaelChen commented 4 years ago

This is similar to #222 except it's triggered when attempting to create a profile build. This also introduces a Deprecation: switch case fallthrough instead but I'm not sure of the best way to resolve that.

adamdruppe commented 4 years ago

where's the switch case fallthrough?

that's generally easily solved by goto case but it might be a legit bug.

i'l just getting my computer powered back up after an electrical thing though so i prolly won't look in full till tomorrow

adamdruppe commented 4 years ago

there we go, the compiler apparently doesn't realize parseError throws so a simple assert(0) silenced the warning

https://github.com/adamdruppe/arsd/commit/c3c863d8674f657ed745cda330e57db51734a53c