search

adamduncan / eleventy-plugin-i18n

Eleventy plugin to assist with internationalization and dictionary translations
MIT License
103 stars 10 forks source link

Add @11ty/eleventy 0.12.x to peerDependencies #13

Closed avdeev closed 3 years ago

avdeev commented 3 years ago

We can't use this plugin with incorrect peerDeps

$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found: @11ty/eleventy@0.12.1
npm ERR! node_modules/@11ty/eleventy
npm ERR!   @11ty/eleventy@"0.12.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @11ty/eleventy@"^0.11.0" from eleventy-plugin-i18n@0.1.1
npm ERR! node_modules/eleventy-plugin-i18n
npm ERR!   eleventy-plugin-i18n@"0.1.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
adamduncan commented 3 years ago

Ah good catch, @avdeev. I'd not spotted the minor update to v0.12.x.

If you can bump our package to version 0.1.2 here, we can get this merged and publish. Thanks!

Side note: Can see 11ty v1.0.0 is in canary now, so not sure if we'll be expecting any more minor releases in the lead-up. Would also be open to set our peerDep to >=0.11.0 <1.0.0 to avoid this issue in the interim.

avdeev commented 3 years ago

Yes, you are right.

I changed peerDeps to >=0.11.0 <1.0.0 and check it. And I bumped the version to 0.1.2 and run npm install on NPM v7 after that.

adamduncan commented 3 years ago

That's great, thanks very much, @avdeev 👍

Published to v0.1.2

avdeev commented 3 years ago

I checked the release in my project. Everything is fine