Tables are being corrupted

adamerose / vscode-markdown-wysiwyg

https://marketplace.visualstudio.com/items?itemName=adamerose.markdown-wysiwyg

Other

19 stars 4 forks source link

Tables are being corrupted #20

Open dejandovzan opened 2 months ago

dejandovzan commented 2 months ago

When adding a table in md file with html. The editor will corrupt the tables when saving the file.

Example:

adding the table in raw format:

<table>
<thead>
    <tr>
        <th colspan="2">Wide Header</th>
    </tr>
</thead>
<tbody>
    <tr>
        <td>r1c1</td>
        <td>r1c2</td>
    </tr>
    <tr>
        <td>r2c1</td>
        <td>r2c2</td>
    </tr>
</tbody>
</table>

then opening the md with extension and saving the file will corrupt the table.

adamerose commented 2 months ago

CKEditor5 converts the HTML to this markdown source:
```
| Wide Header |
| --- |
| r1c1 | r1c2 |
| r2c1 | r2c2 |
```
Which doesn't always render properly...

EDIT - I initially said this was related to Prettier autoformatting but realized that was wrong.

dejandovzan commented 1 month ago

Does it make sense to create the tables in html format?

adamerose commented 1 month ago

Does it make sense to create the tables in html format?

The default behavior of CKE5 is to keep blocks as HTML source if they aren't convertible to markdown. It seems like this is a bug where CKE5 thinks this table is valid in markdown and converts it, but then fails to properly render it. I just created an upstream issue: https://github.com/ckeditor/ckeditor5/issues/16794