adametry / gulp-eslint

A Gulp plugin for identifying and reporting on patterns found in ECMAScript/JavaScript code.
MIT License
563 stars 118 forks source link

Upgrade ESLint from v4 to v5 #224

Closed ehmicky closed 6 years ago

ehmicky commented 6 years ago

This upgrades ESLint to the next version.

At the moment, only 5.0.0-alpha.0 is released, so I will update this pull request with newer versions until a stable version is released.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.31% when pulling 3f0810436feff8f93c5caba31561f673d744f1e0 on ehmicky:upgrade_eslint_v5 into a58a58d95d004271f06c4df31138b859fe73b619 on adametry:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.31% when pulling 2cf9763a42032aa9199ef726d04bc0e5e235e2ad on ehmicky:upgrade_eslint_v5 into a58a58d95d004271f06c4df31138b859fe73b619 on adametry:master.

ehmicky commented 6 years ago

Upgraded to 5.0.0-alpha.1.

Note that ESLint now removed support for Node 4 and 5, which is why the Travis build is failing. I.e. this plugin will have to raise support from Node 4 to Node 6 in order to support latest version of ESLint.

ehmicky commented 6 years ago

Upgraded to 5.0.0-alpha.2

ehmicky commented 6 years ago

Upgraded to 5.0.0-alpha.3

ehmicky commented 6 years ago

Upgraded to 5.0.0-alpha.4

ehmicky commented 6 years ago

Upgraded to 5.0.0-rc.0

shinnn commented 6 years ago

@ehmicky Can you finish this up?

gucong3000 commented 6 years ago

@shinnn We should fix CI fail first: #229

ehmicky commented 6 years ago

I was in summer vacation. Great this got merged!