Upgrade to ESLint 6 - Githubissues

adametry / gulp-eslint

A Gulp plugin for identifying and reporting on patterns found in ECMAScript/JavaScript code.

MIT License

563 stars 118 forks source link

Upgrade to ESLint 6 #235

Closed ehmicky closed 5 years ago

ehmicky commented 5 years ago

To upgrade to eslint 6 the following had to be changed:

ESLint 6 drops support Node for 6, so I updated .travis.yml to only run for Node >=8.10.0.
linter.options.ignore -> linter.isPathIgnored(filePath)
unknown plugin error message changed, so one test had to be updated
tests use file paths internal to eslint (for the formatters). Those had to be updated.

coveralls commented 5 years ago

Coverage remained the same at 99.31% when pulling f0792355bc23b1ae02ce88f6696b00d7bee67d35 on ehmicky:feature/eslint-v6 into 40d004fa2f48325f6a507cb10072ff6667aeaf41 on adametry:master.

ehmicky commented 5 years ago

Tests are now passing on CI.

@shinnn

shinnn commented 5 years ago

@ehmicky Would you be interested in joining the project as a maintainer? I’ve been impressed with your continuous contributions on execa, and unfortunately I don’t have enough motivation to maintain this project as I personally no longer use gulp.

ehmicky commented 5 years ago

I've fixed the CHANGELOG.

Thanks for the invitation (and your mention of my work on execa)! I am very interested in both ESLint and Gulp. However right now I am working on too many projects at the same time, so I'm not sure whether I should add another one to maintain. Could this invitation extend to the future, where I might have fewer projects to work on?

shinnn commented 5 years ago

Could this invitation extend to the future, where I might have fewer projects to work on?

Sure. I appreciate your kind response!

For now I’m merging this and will publish a new version by myself.

shinnn commented 5 years ago

https://github.com/adametry/gulp-eslint/releases/tag/v6.0.0