search

adamfeuer / rotate-backups

Rotate Backups - keep hourly, daily, and weekly backups
Other
82 stars 25 forks source link

Daily backups cannot be deleted #11

Closed ben-novanus closed 10 years ago

ben-novanus commented 10 years ago

Ubuntu 12.04, Python 2.7.3

Daily backups are backing up because the rotate script cannot remove daily backup folders.

$ /home/ftb/scripts/rotate-backups/rotate-backups.py Traceback (most recent call last): File "/home/ftb/scripts/rotate-backups/rotate-backups.py", line 337, in account.rotate_dailies() File "/home/ftb/scripts/rotate-backups/rotate-backups.py", line 235, in rotate_dailies daily.remove() File "/home/ftb/scripts/rotate-backups/rotate-backups.py", line 285, in remove os.remove(self.path_to_file) OSError: [Errno 21] Is a directory: '/home/ubuntuone/myserver_backup/ftb/direwolf20_1_5v2/archives/world/daily/world-2013-10-08-0303.tar.bz2'

/home/ubuntuone/myserver_backup/ftb/direwolf20_1_5v2/archives/world/daily/world-2013-10-08-0303.tar.bz2 is a folder, and inside it is the world-2013-11-21-0307.tar.bz2

I assume that this is related to https://github.com/adamfeuer/rotate-backups/pull/7 because it moves the folder to dailies instead of just the archive. I think that having a folder named the same as the archive is redundant and it should be just the bz2 file.

adamfeuer commented 10 years ago

Do you have the latest source?

-adam

On Thu, Nov 21, 2013 at 7:19 AM, draggy notifications@github.com wrote:

Ubuntu 12.04, Python 2.7.3 I use https://github.com/Ahtenus/minecraft-init with this rotate backup script.

Daily backups are backing up because the rotate script cannot remove daily backup folders.

$ /home/ftb/scripts/rotate-backups/rotate-backups.py Traceback (most recent call last): File "/home/ftb/scripts/rotate-backups/rotate-backups.py", line 337, in account.rotate_dailies() File "/home/ftb/scripts/rotate-backups/rotate-backups.py", line 235, in rotate_dailies daily.remove() File "/home/ftb/scripts/rotate-backups/rotate-backups.py", line 285, in remove os.remove(self.path_to_file) OSError: [Errno 21] Is a directory: '/home/ubuntuone/myserver_backup/ftb/direwolf20_1_5v2/archives/world/daily/world-2013-10-08-0303.tar.bz2'

/home/ubuntuone/myserver_backup/ftb/direwolf20_1_5v2/archives/world/daily/world-2013-10-08-0303.tar.bz2 is a folder, and inside it is the world-2013-11-21-0307.tar.bz2

— Reply to this email directly or view it on GitHubhttps://github.com/adamfeuer/rotate-backups/issues/11 .

Adam Feuer adam@adamfeuer.com

ben-novanus commented 10 years ago

yes, I did a pull earlier and tried it with the same results.

ben-novanus commented 10 years ago

It looks like this error is left over from the old version of the script.

The old version created the unnecessary daily archive folders, the new script does not. But it also cannot delete the old archive folders, so that was why there was an error.

adamfeuer commented 10 years ago

Thanks for letting me know!

On Tue, Nov 26, 2013 at 7:33 AM, draggy notifications@github.com wrote:

It looks like this error is left over from the old version of the script.

The old version created the unnecessary daily archive folders, the new script does not. But it also cannot delete the old archive folders, so that was why there was an error.

— Reply to this email directly or view it on GitHubhttps://github.com/adamfeuer/rotate-backups/issues/11#issuecomment-29301639 .

Adam Feuer adamf@pobox.com