search

adamfowlerit / msportals.io

MSPortals.io - Microsoft Administrator Sites, Training, and Licensing Resources
https://msportals.io/
237 stars 99 forks source link

Favorites Icons not showing #232

Closed adamfowlerit closed 6 months ago

adamfowlerit commented 1 year ago

Describe the bug

In the Favorites section, links saved have just text for the icons (such as aka.ms or B2B)

To Reproduce

Steps to reproduce the behavior:

Add a site to favorites that has icons Go to favorites.

Expected behavior

Icons should be showing

Screenshots

image

Desktop (please complete the following information)

Smartphone (please complete the following information)

Additional context

Add any other context about the problem here.

PsychoData commented 6 months ago

This will be an artifact of how it copies to the favorites page.... hmmm... I think I might be able to copy it over with some different code instead, so that it will maintain the icons instead.

I'll look at it tomorrow

PsychoData commented 6 months ago

fixed in https://github.com/adamfowlerit/msportals.io/commit/84af43c61b449bf49a34010c21742d4f26474e8d

Luckily, this is actually stored in the "Saved" pages as JSON, so this should retro-actively fix any that were previously saved as well! Your browser may try to cache the old version of the HTML, but testing with InPrivate mode, or clearing your browser cache should fix it if you are still seeing this 😄 gml2Y6k 1