search

adamgibbons / ics

iCalendar (ics) file generator for node.js
ISC License
715 stars 152 forks source link

Revert "Allow `organiser` to contain comma, ensure that new lines in values don't break output, and various other tweaks" #260

Closed adamgibbons closed 9 months ago

adamgibbons commented 9 months ago

Reverts adamgibbons/ics#252 (tests failing)

tjenkinson commented 9 months ago

@adamgibbons which tests failed?

npm t works fine locally 🤔

adamgibbons commented 9 months ago

I admittedly didn't dig too deep, but after a clean install, nvm use, npm ci, npm test here's what I was seeing on master:

Screen Shot 2023-12-13 at 9 53 00 AM
adamgibbons commented 9 months ago

It's very possible a Node versioning issue - I'll look into upgrading Node.

tjenkinson commented 9 months ago

Aaah yes I think your node doesn't have replaceAll yet. I can update those calls if you like to use replace instead?

adamgibbons commented 9 months ago

@tjenkinson sorry for the runaround - I've just upgraded to Node 18 and will try to restore/merge your branch. That's what I get for falling behind on Node! 🤦‍♂️

tjenkinson commented 9 months ago

Aha no problem :)