Closed nwithan8 closed 4 years ago
Hello @nwithan8! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
plexlibrary/plexlibrary.py
:Line 46:80: E501 line too long (93 > 79 characters)
plexlibrary/plexutils.py
:Line 41:80: E501 line too long (83 > 79 characters) Line 63:80: E501 line too long (84 > 79 characters) Line 69:80: E501 line too long (82 > 79 characters) Line 84:9: E722 do not use bare 'except'
plexlibrary/recipe.py
:Line 31:80: E501 line too long (92 > 79 characters) Line 182:80: E501 line too long (88 > 79 characters) Line 209:80: E501 line too long (98 > 79 characters) Line 280:80: E501 line too long (102 > 79 characters) Line 392:80: E501 line too long (97 > 79 characters) Line 431:80: E501 line too long (86 > 79 characters) Line 433:80: E501 line too long (116 > 79 characters) Line 586:80: E501 line too long (109 > 79 characters) Line 591:80: E501 line too long (120 > 79 characters) Line 593:80: E501 line too long (117 > 79 characters) Line 596:80: E501 line too long (114 > 79 characters) Line 597:80: E501 line too long (108 > 79 characters) Line 598:80: E501 line too long (80 > 79 characters) Line 601:80: E501 line too long (80 > 79 characters) Line 602:80: E501 line too long (101 > 79 characters) Line 606:80: E501 line too long (105 > 79 characters) Line 608:80: E501 line too long (121 > 79 characters) Line 610:80: E501 line too long (146 > 79 characters) Line 618:80: E501 line too long (102 > 79 characters) Line 620:80: E501 line too long (117 > 79 characters) Line 622:80: E501 line too long (129 > 79 characters)
plexlibrary/traktutils.py
:Line 62:80: E501 line too long (82 > 79 characters)
Fantastic job, thank you so much for cleaning up the code! I found some bugs while testing, but they weren't in your code and it should merge without issues.
-p
flag to use playlists rather than libraries for lists, for those who don't want to worry about symbolic links. This also saves time for metadata refreshing. Playlist is created if it doesn't exist;remove_from_playlist
option in config indicates whether user wants to continuously add to the playlist, or purge and recreate it on each refresh.recipe.py
. To accommodate for the playlist functionality, I went ahead and broke up the long chain of instructions into smaller functions. Reduces overall line count since most functions are called in bothrun
andrun_sort_only
.plexutils.py
file, new methods to assist with playlist creation and modification.