search

adamgreen / mri

MRI - Monitor for Remote Inspection. The gdb compatible debug monitor for Cortex-M devices.
Apache License 2.0
155 stars 57 forks source link

Move GdbStats from semihost/mbed/semihost_mbed.c to core/fileio.h #17

Closed xiaoxiang781216 closed 2 years ago

xiaoxiang781216 commented 2 years ago

so other semihost implementation can share the same definition

adamgreen commented 2 years ago

For your scenario, is it ok that the public version uses my longer field names rather than what is used in the GDB documentation?

xiaoxiang781216 commented 2 years ago

For your scenario, is it ok that the public version uses my longer field names rather than what is used in the GDB documentation?

It's fine with either, since the code always need do some conversion: https://github.com/xiaoxiang781216/mri/commit/2156cfd7fb9a98885542068571df5fbba09f38e8#diff-47a410aee47f698e7848121747591de7110ae9c1d8bede55d89a4d0f27a7bf35R112-R132 The key point is avoid the naming conflict since NuttX(https://github.com/apache/incubator-nuttx) define many POSIX symbols.