adamgreig
commented
7 years ago This looks great, thank you!
Before I merge it, could you make sure it's PEP8 compliant please? You can run pep8.py or a similar checker against it. There are just a few things - some missing/extra spaces and some lines longer than 79 chars - that need fixing. If you don't have time I can do it this evening instead.
stickerbom.py:30:49: E203 whitespace before ':'
stickerbom.py:62:80: E501 line too long (80 > 79 characters)
stickerbom.py:167:27: E231 missing whitespace after ','
stickerbom.py:173:18: E225 missing whitespace around operator
stickerbom.py:180:80: E501 line too long (110 > 79 characters)
stickerbom.py:246:13: E265 block comment should start with '# '
stickerbom.py:262:29: E231 missing whitespace after ','
stickerbom.py:262:39: E231 missing whitespace after ','
stickerbom.py:566:42: E231 missing whitespace after ','
stickerbom.py:566:49: E231 missing whitespace after ','
stickerbom.py:567:80: E501 line too long (80 > 79 characters)
stickerbom.py:569:42: E231 missing whitespace after ','
stickerbom.py:569:49: E231 missing whitespace after ','
stickerbom.py:569:80: E501 line too long (91 > 79 characters)
stickerbom.py:574:42: E231 missing whitespace after ','
stickerbom.py:574:49: E231 missing whitespace after ','
stickerbom.py:578:42: E231 missing whitespace after ','
stickerbom.py:578:49: E231 missing whitespace after ','
stickerbom.py:578:80: E501 line too long (91 > 79 characters)
Fixes #29. Components with all of their modules on the bottom side of the board will show a render of that side instead, and components with modules on both sides will split the view in half.
The system to parse and render modules now stores all graphics objects by layer, and is reasonably easy now to select different layers to render. The existing functionality where a module is shown as the fab drawing, and if that doesn't exist falls back to the copper and silkscreen is preserved, but is also now fairly easy to adjust.