adamhaile / surplus

High performance JSX web views for S.js applications
639 stars 26 forks source link

Remove generated code from this repository #51

Open brodycj opened 6 years ago

brodycj commented 6 years ago

Use npm prepare script to generate needed objects before publishing. For example:

I would be happy to help with this one if you like. Maybe within the next 1-2 weeks.

adamhaile commented 6 years ago

FWIW, I'm currently checking in the built assets for two reasons: 1) (small reason) it makes it marginally easier to have some scratch and demo scripts that run against current master, and 2) (bigger) b/c I'm transpiling from typescript, I manually review the generated code to make sure the transpiler didn't introduce any non-performant patterns. Having the built assets checked in makes that very easy -- I just check the changed sections in the diff.

If I start getting substantial community contributions to the code, I'll probably flip the other way.