search

adamhalasz / uniqid

Unique ID Generator
https://adamhalasz.com
617 stars 49 forks source link

Application breaks when using strict mode because of dependency macaddress #6

Closed nerdbeere closed 6 years ago

nerdbeere commented 8 years ago

Hey there,

I use uniqid in my project but it breaks because of your dependency to macaddress when using strict mode. See this issue here: https://github.com/scravy/node-macaddress/issues/7

adamhalasz commented 8 years ago

Hey @nerdbeere

Uh oh lots of issues coming from this dependecy haha Let's see what the author will say in his response.

Thanks, Adam

nerdbeere commented 8 years ago

It doesn't look like he's caring much. I think it would be really cool for uniqid if it wouldn't rely on any dependencies.

Hypnosphi commented 6 years ago

There's one more problem with this dependency

https://nodesecurity.io/advisories/654 https://github.com/scravy/node-macaddress/issues/19#issuecomment-390495906

adamhalasz commented 6 years ago

Hi everyone, I removed the macaddress dependency in the new v5.0.0, so this issue should be fixed. And sorry for the late response.