adamhalasz / uniqid

Unique ID Generator
https://adamhalasz.com
617 stars 49 forks source link

dependency macaddress has a global leak #8

Closed defunctzombie closed 6 years ago

defunctzombie commented 8 years ago

They have fixed it (https://github.com/scravy/node-macaddress/commit/67e7f938c3acc90d5950c88b749fd6a15eb401db) but have not released a new version for a long time.

Would be nice to either publish a fork of theirs (if the author isn't going to update) and depend on that until there is an actual update.

Issue asking them to release a new version: https://github.com/scravy/node-macaddress/issues/9

anshu300 commented 6 years ago

how uniqid id genrate only number formate like (123456789) and length 8 to 10

harshitgupta commented 6 years ago

The issue has been fixed https://github.com/scravy/node-macaddress/commits/master 0.2.9 released. Please update the dependency version in this repo. Thanks

ntwb commented 6 years ago

The link above doesn't work here's that link https://github.com/scravy/node-macaddress/commits/master, also the 2.9.0 version has not been released to nmjs.com nor tagged 2.9.0 in the repo

https://www.npmjs.com/package/macaddress?activeTab=versions

anajavi commented 6 years ago

The macaddress can also be acquired in newer node releases with:

require('os').networkInterfaces()

So dropping support for older node would help here.

eladcandroid commented 6 years ago

And here's the "npm audit" critical issue: screen shot 2018-05-23 at 11 28 22

adamhalasz commented 6 years ago

Hi everyone, I removed the macaddress dependency in the new v5.0.0, so this issue should be fixed. And sorry for the late response.

screen shot 2018-06-03 at 4 59 29 pm

Let me know if there are any other issues.

Thanks, Adam