search

adamhathcock / sharpcompress

SharpCompress is a fully managed C# library to deal with many compression types and formats.
MIT License
2.24k stars 480 forks source link

BZip2Stream's new constructor parameter? #386

Open sbrl opened 6 years ago

sbrl commented 6 years ago

Hello,

I'm using SharpCompress to compress chunk data in my project sbrl/Nibriboard, and I've just updated to the latest version of SharpCompress.

Lo and behold, I found that I had a build error, as I needed to specify a value for the new constructor parameter decompressConcatenated. Upon reading SharpCompress' documentation and code, however, I'm still none the wiser as to what it does (the intellisense comment simply says "Decompress concatenated", which isn't particularly helpful).

Can you help? Right now I've just randomly set it to false, but I'd like to know what I'm doing here :P

adamhathcock commented 6 years ago

It's not really new. https://github.com/adamhathcock/sharpcompress/issues/166 explains more if you scroll towards the end.

sbrl commented 6 years ago

Ah, I see. Perhaps the intellisense description could be updated to be more meaningful then? Herpas something like this:

Decompress all blocks in the stream and concatenate them. Big bzip2 files can contain multiple blocks.

...perhaps?