ZipArchive.RemoveEntry slow when removing in bulk

adamhathcock / sharpcompress

SharpCompress is a fully managed C# library to deal with many compression types and formats.

MIT License

2.27k stars 481 forks source link

ZipArchive.RemoveEntry slow when removing in bulk #520

Open DigVolSoft opened 4 years ago

DigVolSoft commented 4 years ago

Nice library, thanks.

I've found that ZipArchive.RemoveEntry is slow when removing many entries (e.g. 1,000 in an archive of 60,000). It starts off ok but slows down to 1 file per second fairly quickly.

Could this be an issue of re-building between each removal, similar to https://github.com/adamhathcock/sharpcompress/pull/485 ?

thanks

adamhathcock commented 4 years ago

Probably. Did you use the method in your code?

DigVolSoft commented 4 years ago

Not in anything final - just currently experimenting with the library as it has nice support for multiple formats.