search

adamhathcock / sharpcompress

SharpCompress is a fully managed C# library to deal with many compression types and formats.
MIT License
2.28k stars 480 forks source link

LHA archive decompression support added #731

Closed TwanVanDongen closed 9 months ago

TwanVanDongen commented 1 year ago

LHA Archive support added for decompression of methods lh0, lh5, lh6 and lh7. Others will be added when test-archives are created. Implementation taken from LHA Decompressor for .NET.

TwanVanDongen commented 1 year ago

Never heard of LHA!

Some minor things but the major is the LICENSE which is LGPL and we're MIT

Unless you got permission, I can't accept code from https://github.com/benbaker76/LHADecompressor/tree/master unfortunately

Received confirmation from Headkaze's to use his C# port of LHADecompressor (" I have no problem with you using my port. I believe it's the same license as the original source. If it complies then it shouldn't be a problem."). This however only resolved the porting, now trying to connect the original Java developer (Nobuyasu SUEHIRO) with the same question.

vpenades commented 1 year ago

Suggestion: If the problem is only the license, an alternative approach would be this:

Create a separate project library called SharpCompress.ArchiveFormat.LHA (or something like that) which would use the LGPL license, so it would be license compatible.

Users willing to use LHA would require:

adamhathcock commented 1 year ago

that's a good call, to do that. Can register factories at start up now with little code