search

adamhathcock / sharpcompress

SharpCompress is a fully managed C# library to deal with many compression types and formats.
MIT License
2.27k stars 480 forks source link

There are some rar compression packages that do not throw an exception if no password is entered #743

Open yousa121380 opened 1 year ago

yousa121380 commented 1 year ago

Unzipping the following package using the example in the USAGE.md will throws an NullReferenceException image This is a rar package I downloaded from the Internet https://dz.certdon.com/down/2022down/3/18/NatTypeTesterrj.rar

yousa121380 commented 1 year ago

mabe this is same issue https://github.com/adamhathcock/sharpcompress/issues/514#issuecomment-818490327

Erior commented 1 year ago

The link does not work for me ERR_NAME_NOT_RESOLVED

yousa121380 commented 1 year ago

The link does not work for me ERR_NAME_NOT_RESOLVED

After work I pull a request and put it in testcase

yousa121380 commented 1 year ago

https://github.com/adamhathcock/sharpcompress/pull/744 i upload and add it@Erior

Erior commented 1 year ago

@yousa121380 , I created a pull where we now can skip over the encrypted files instead of throwing an exception, I guess that is what you were after?

yousa121380 commented 1 year ago

@yousa121380 , I created a pull where we now can skip over the encrypted files instead of throwing an exception, I guess that is what you were after?

yes, i test encrypted zip and it can throw exception then skip over, i want that it have same behave in all encrypted files