search

adamhathcock / sharpcompress

SharpCompress is a fully managed C# library to deal with many compression types and formats.
MIT License
2.29k stars 482 forks source link

ReaderFactory not iterating over big entries #795

Open jbrockerville opened 10 months ago

jbrockerville commented 10 months ago

I've encountered an issue with the ReaderFactory and ZIP archives with "big" entries. If an archive has a sufficiently big enough entry, the reader fails to iterate over all the entries. No error. Just no next entry and drops out of the loop. The ArchiveFactory seems fine. Please see the attached code for generating the archive ("data/data.py") and reproducing the bug. Here is the output I get:

Entries via ReaderFactory...
  bin1.bin
Entries via ArchiveFactory...
  bin1.bin
  a.txt
  c.txt

BigArchive.zip

adamhathcock commented 10 months ago

Maybe https://github.com/adamhathcock/sharpcompress/pull/799 will address

DannyBoyk commented 10 months ago

Latest SharpCompress code produces identical results for ReaderFactory and ArchiveFactory, so it appears this can be closed out.