search

adamhathcock / sharpcompress

SharpCompress is a fully managed C# library to deal with many compression types and formats.
MIT License
2.25k stars 479 forks source link

.NET Core 4.5 assembly is not strong named in the NuGet Package #8

Closed daniel-chambers closed 10 years ago

daniel-chambers commented 10 years ago

In the 0.10.1.3 version of the NuGet package, the .NET 4 and PCL assemblies are strong named, but the .NET Core 4.5 assembly is not.

This is causing an assembly loading failure in my Windows 8.1 App project because I'm using another PCL package that depends on SharpCompress. When I install that other library, NuGet brings SharpCompress along as a dependency, and installs the .NET Core 4.5 version instead of the PCL version. Then at runtime, that other library fails to load SharpCompress because the .NET Core 4.5 SharpCompress assembly is not strong named, but the other package is bound to the strong named PCL version.

adamhathcock commented 10 years ago

Fixed https://github.com/adamhathcock/sharpcompress/commit/c4b005b3d4afe7a9093e251b6849ae75b85e0629

Should be in next release (10.2)