search

adamhsparks / ChickpeaAscoDispersal

Chickpea _Ascochyta rabiei_ Spore Dispersal Modelling
https://adamhsparks.github.io/ChickpeaAscoDispersal/
3 stars 1 forks source link

Code review Weather_data.Rmd #2

Closed adamhsparks closed 4 years ago

adamhsparks commented 4 years ago

@PaulMelloy, could you go through my Weather_data.Rmd file and please code review it for me to make sure it's doing what we want?

I've set it up to have a clear path from the raw weather data to the data we use.

I need to add the calculations for the event itself, the mean direction, speed and sum of rainfall (or you can in the last step before writing the CSV file, if you'd like, but please use Tidyverse if you do.

https://github.com/adamhsparks/Chickpea_AB_Modelling/blob/master/Weather_data.Rmd

thanks

PaulMelloy commented 4 years ago

All done, Have a quick check through to see if is what you want. Also if you could respond to the issue #3 that would be super.

adamhsparks commented 4 years ago

Thanks, Paul, for a nice code review and the changes.