adamin1990 / mp4parser

Automatically exported from code.google.com/p/mp4parser
0 stars 0 forks source link

CroppedTrack.java confused with index and sample number value #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.capture a video with only 1 sync sample
2.try the ShortenExample.java with time set to, let's say, 0~5 seconds
3.it crashes

What is the expected output? What do you see instead?
the cropped video should have the entire video

What version of the product are you using? On what operating system?
using the code from svn

Please provide any additional information below.

The CroppedTrack.java doesn't differentiate array index and value so clearly. 
When you call getSyncSamples(), the first value (not the index) is 0 instead of 
1. But if you try it on original track, it is 1. 

I've attached my corrected version, but it's not thoroughly tested. Hope it 
helps your debugging and fixing.

Original issue reported on code.google.com by LIUF0...@gmail.com on 23 Oct 2011 at 8:34

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by LIUF0...@gmail.com on 23 Oct 2011 at 8:46

Attachments:

GoogleCodeExporter commented 9 years ago
Hi, 
I was just checking your error description and with my file and revision r250 
the first sync sample is 1. Is it perhaps your file in combination with my 
software. If you can reproduce it again could you please attach the file? 
When I applied your patch I got an IndexOutOfBounds Exception. Thank You for 
helping to make this software better!

BR,
Sebastian

Original comment by Sebastian.Annies on 4 Nov 2011 at 6:26

GoogleCodeExporter commented 9 years ago

Original comment by Sebastian.Annies on 5 Nov 2011 at 7:54

GoogleCodeExporter commented 9 years ago
I'm closing the issue. You can re-open at any time but at the moment I think it 
is resolved - somehow.

Original comment by Sebastian.Annies on 22 Nov 2011 at 11:56