BrowseApi.search fails on 3.5.04, Android with ProGuard enabled

[adamint]

Relevant conversation, as reported by @Nielssg:

Niels02/03/2021
I seem to find an issue when using the search endpoint in the most recent version of the library (Android). The weird part is that it only seems to happen when using Android with Proguard, without Proguard it works just fine. In seems to be isolated to the Search api, as I can use the rest of the endpoints without problems. I was wondering if anything has changed that could cause this issue, or if I'm doing something wrong?

note: I think it's specifically isolated to spotifyApi.search.search(). It doesn't matter which searchType you enter, or if you use searchAllTypes, it will fail.

Adam02/03/2021
@Niels could you try to use getArtistAlbums
my suspicion is that it's either the fact that id is internal in SearchType or because it's a nested enum
using getArtistAlbums could rule out the second

NielsYesterday at 12:05 PM
getArtist, getArtistAlbums and their top tracks does not seem to crash

NielsYesterday at 12:15 PM
I can also confirm, using the separate calls (e.g. .searchARtist, .searchAlbum, .searchPlaylist, .searchTrack) seems fine, it is probably isolated to solely the search.search function

AdamYesterday at 1:59 PM
huh, thanks for the info. does still seem like it’s related to enums. I’ll open an issue and look into it

NielsYesterday at 3:25 PM
Yeah weird issue, wish I could find out what the problem is, any changes to the search endpoint which could cause it? I previously had v3.2.14, which I believe did not have the problem

AdamYesterday at 10:03 PM
Hmm, ok.. there was this issue with search before, but I thought it was fixed
which version is this?

NielsToday at 2:46 AM
3.2.14 does not have the issue, the latest 3.5.04 does have it, though I think it might have slipped in inbetwee n

AdamToday at 9:31 AM
Sorry for asking, and it’s totally fine if you’re not able to, but would it be possible to test a 3.3.x and 3.4.x version?
I’m guessing it’s a dependency added between 3.2 and 3.5
(probably klock)

[adamint]

As this is a regression, need to look into dependency changes from 3.2.14 -> 3.5.04. Also, the git blame for BrowseApi

[adamint]

@Nielssg do you know if this is still an issue?

[Nielssg]

@adamint Sorry for the late response, I'll try to test it out in the coming week

[Nielssg]

@adamint I cannot bring up the issue anymore, it seems to be fixed 🤔. Might be good to just close the issue and re-open it if it ever occurs again?

[adamint]

Great, thanks for testing it out!