search

adamint / spotify-web-api-kotlin

Spotify Web API wrapper for Kotlin, Java, JS, and Native - Targets JVM, Android, JS (browser), Native (Desktop), and Apple tvOS/iOS. Includes a Spotify Web Playback SDK wrapper for Kotlin/JS, and a spotify-auth wrapper for Kotlin/Android.
https://adamint.github.io/spotify-web-api-kotlin-docs/
MIT License
194 stars 21 forks source link

Fixed issue where endpoint would infinitely retry for a nullable resource (#312) #313

Closed Nielssg closed 2 years ago

Nielssg commented 2 years ago

Recently a new method in Endpoints.kt called "getNullable" has been added. However, the execute method was not appropriately changed, leading to the method infinitely retrying the request when the result was null.

Closes #312

adamint commented 2 years ago

this breaks a test, I’ll look into it

adamint commented 2 years ago

/ok-to-test 28e45fe

adamint commented 2 years ago

Thanks @Nielssg, tests passed but the action status is bugged. No qualms on the code, it looks good