search

adamint / spotify-web-api-kotlin

Spotify Web API wrapper for Kotlin, Java, JS, and Native - Targets JVM, Android, JS (browser), Native (Desktop), and Apple tvOS/iOS. Includes a Spotify Web Playback SDK wrapper for Kotlin/JS, and a spotify-auth wrapper for Kotlin/Android.
https://adamint.github.io/spotify-web-api-kotlin-docs/
MIT License
194 stars 21 forks source link

Build failing because of PKCE and Implicit layouts #323

Closed BobbyESP closed 1 year ago

BobbyESP commented 1 year ago

Describe the bug When trying to build the app with the version 4.0.0 of the library, the build fails with AAPT errors

To Reproduce Steps to reproduce the behavior:

  1. Add the version 4.0.0 of the library to the build.gradle file in an Android project
  2. Try to build the app
  3. See the errors

Expected behavior I wanted the app to build successfully

Screenshots

image image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context It's for my Spowlo app, you can see in there the source code

adamint commented 1 year ago

Hi @BobbyESP, can you share your build.gradle.kts? How are you referencing this library? edit: I see the problem, never mind. Thank you for reporting, I am looking into it and should have a fix out soon. In the meantime, please stick with 3.x

BobbyESP commented 1 year ago

Hi! Thank you for the answer! If you still need the build.gradle.kts tell mell and I sent it to you! By the way you can see it the the repo that I left in the additional context :)

BobbyESP commented 1 year ago

Any updates on this?

BobbyESP commented 1 year ago
image

This should fix the issue

adamint commented 1 year ago

Closing with 4.0.1 release. Please try!

Lightningtow commented 1 year ago

Unfortunately, whatever changed with 4.0.1 didn't do the trick. Fails to build with both spotify-api-kotlin-android:4.0.1 and spotify-api-kotlin-core:4.0.1. Tried cleaning, rebuilding, and invalidating the cache to no avail. image

adamint commented 1 year ago

Ugh, thanks for checking. Sorry @Lightningtow. I'll just remove temporarily the content and allow user-set loading content, and will ping when a new release is out in a few hours.

Lightningtow commented 1 year ago

@adamint sounds good, thank you! Btw BobbyESP's fix above worked for me when attempting to patch a local copy of the library, might work in general too

adamint commented 1 year ago

I've had a lot of problems with this progress bar library, so thought it might be best to remove and allow people who want a loading animation to insert it themselves!

@Lightningtow this should actually compile now, confirmed in my sample app. 4.0.2 is in sync now, not sure if you're able to access it at the moment or will need to wait a few hours for maven central sync

BobbyESP commented 1 year ago

Thank you guys for helping fix the probldm!