search

adamjakab / BeetsPluginDescribe

A beets plugin for obsessive-compulsive music geeks to describe what's in their library.
MIT License
18 stars 2 forks source link

from confit to confuse #5

Closed Bastes closed 2 years ago

Bastes commented 2 years ago

This should fix https://github.com/adamjakab/BeetsPluginDescribe/issues/4 (deprecations warning for the old beets config lib).

This has been tested by @JOJ0 and seems to work, removing the warnings.

JOJ0 commented 2 years ago

@adamjakab could you take a quick look. I think it's safe to merge since @sampsyo wrote confuse as a drop-in replacement for beets.util.confit.

Bastes commented 2 years ago

@adamjakab?

JOJ0 commented 2 years ago

Hi @adamjakab do you think you will continue mantaining this plugin or would it be better if someone else would host it. Or ask beets maintainers if they want to bring it nto the main repo is another idea, not sure.

Please get back to us with any thoughts! Thanks in advance!

adamjakab commented 2 years ago

Hi @JOJ0 / @Bastes and everyone else who commented and created requests to this repo. It cannot say that I can continue to contribute to this repo in any sensible way at the moment. I even have difficulties validating and merging this PR. Is there a way to give co-ownership to a few of you guys willing to improve this plugin? I would be happy to do it.

adamjakab commented 2 years ago

Thanks @Bastes - merged and created new release v0.0.4 - also triggering PyPi package build.

JOJ0 commented 2 years ago

Hi @adamjakab, thanks for merging this. As you probably realized already a lot of talking in this PR was not about the fix but on how one could use the plugin from a fork to get the fix already. Sorry for hijacking!

On your very interesting and generous offer of co-ownership for this repo. I did think it over by know and have to admit that for me personally, even though I think it's a very useful and pretty awesome plugin, I don't have enough interest and personal "need" for willing to sensibly maintain it.

(I'm maintaining and co-maintaining 2 open source projects with a little userbase already and don't find too much time for them already)

If it's a general thing / idea of yours to have co-ownerships for your beets plugins. The one I'm personally really interested in and might be willing to help is the xtractor - I don't know if you have heard of, but AcousticBrainz is discontinued (submissions next month, reading existing data will go down early 2023, they say: https://blog.metabrainz.org/2022/02/16/acousticbrainz-making-a-hard-decision-to-end-the-project/) but as far as I can see the Essentia tools are still under active development.

So now your plugin, equally to AB using the Essentia tools, is getting even more important / interesting for those who want to keep fetching analysis information into their collecions. I even was working with the beets maintainers on supporting to writing of this information to actual file tags and had in mind to bring this change over to your plugin as well.

JOJ0 commented 2 years ago

On another note: There is exactly the same deprecation warning on some of your other plugins. PR's with the change are open already. I can't tell 100% for sure but at least can tell you that I personally fixed those with exactly the changes in the PR's and don't have any problems. I even assume that beets main maintainer Adrian S. even thought about that change in third party plugins and coded the confuse library as a drop-in replacement for the beets built-in config module that was confit. So in short I think those proposed changes are pretty safe for you to merge whithout too much hassle:

HTH, and thanks for your awesome plugins! :-)

Bastes commented 2 years ago

Hey @adamjakab, thanks a lot for the merging :) sadly I won't candidate to the co-maintainer post, as my python skills are pretty much inexistant by now, but maybe I'll reconsider in the future should I take a lever in snake handling ;)

adamjakab commented 2 years ago

On another note: There is exactly the same deprecation warning on some of your other plugins. PR's with the change are open already. I can't tell 100% for sure but at least can tell you that I personally fixed those with exactly the changes in the PR's and don't have any problems. I even assume that beets main maintainer Adrian S. even thought about that change in third party plugins and coded the confuse library as a drop-in replacement for the beets built-in config module that was confit. So in short I think those proposed changes are pretty safe for you to merge whithout too much hassle:

* [Substitute import of deprecated module BeetsPluginGoingRunning#28](https://github.com/adamjakab/BeetsPluginGoingRunning/pull/28)

* [Substitute import of deprecated module BeetsPluginXtractor#13](https://github.com/adamjakab/BeetsPluginXtractor/pull/13)

* [Fix deprecation warning (util.confit -> confuse) BeetsPluginYearFixer#5](https://github.com/adamjakab/BeetsPluginYearFixer/pull/5)

HTH, and thanks for your awesome plugins! :-)

all repos have been fixed now

adamjakab commented 2 years ago

If it's a general thing / idea of yours to have co-ownerships for your beets plugins. The one I'm personally really interested in and might be willing to help is the xtractor - I don't know if you have heard of, but AcousticBrainz is discontinued (submissions next month, reading existing data will go down early 2023, they say: https://blog.metabrainz.org/2022/02/16/acousticbrainz-making-a-hard-decision-to-end-the-project/) but as far as I can see the Essentia tools are still under active development.

So now your plugin, equally to AB using the Essentia tools, is getting even more important / interesting for those who want to keep fetching analysis information into their collections. I even was working with the beets maintainers on supporting to writing of this information to actual file tags and had in mind to bring this change over to your plugin as well.

@JOJ0 - That would be the XTractor plugin. I have written these plugins to the open source community and in particular to the beets community. Everyone is welcome to contribute. However you know how these things go... we have other things in our lives.. so even with simple contributions like the PRs these days I had difficulties finding the time to merge them. Co-authoring a project would make it a shared task. I invited you to be a collaborator to the repo. Let's take it up one day and exchange some ideas.

JOJ0 commented 2 years ago

Thanks for the invitation I happily accept it. I have gathered quite some information during the last 2 months about AB, Essentia and people involved with it and will try to provide a summary about it soon. It most probably will happen in an open PR in the beets repo itself. I will pin you there once I found the time to write it. Thanks again!

adamjakab commented 2 years ago

Great. I am happy to hear. I am also very sad to see AB go. With the Xtractor plugin I had two things on the roadmap:

It seems that I waited too long with the first one and it is now too late. I read your reflections on the AB announcement page and I fully agree on the quality/precision feedback. But I am sure this hard decision from the maintainers were pondered and sadly we all have to live up to a cost-benefit analysis at one point or another.

However I am really happy that the second one is the same that you mentioned above. That makes sense - it will not be the same as sharing the info in a centralized public db but still it can be shared and distributed another way. Looking forward to working with you on this one.