Textbox update

[adamjarling]

From UX feedback April 8, 2021

[adamjarling]

@jessvu Ok, I think I understand this from the attached video. Question, would this behavior change if we don't have time to implement a font re-sizing control in the adjustment bar?

[jessvu]

If we don't have time to implement the font re-sizing control, I think we should keep the ability to drag in-out with the corner anchors to adjust size if possible

[adamjarling]

Ok, I'll keep this issue open but just push it back to make sure we get the other stuff completed first.

[jaimemears]

Courtney agrees that the font re-sizing is a low priority "nice to have" @CourtneyMcClellan

[CourtneyMcClellan]

@jaimemears and I are both having issues with moving/adjusting text. We think this is very important to the functionality of the tool in order to annotate items for users but also for the upcoming user annotation. I have attached a video showing my difficulty in selecting and moving the text. https://user-images.githubusercontent.com/77364108/117197258-9a0a8a80-adb5-11eb-8099-61fcd0bb261a.mov

https://user-images.githubusercontent.com/77364108/117197258-9a0a8a80-adb5-11eb-8099-61fcd0bb261a.mov

[adamjarling]

@CourtneyMcClellan So this is related either in part or in full to this issue, which was at the top of the "To do" column over the weekend. I pitched a question on it, but never heard back.

https://github.com/adamjarling/loc-speculative-annotations/issues/65https://github.com/adamjarling/loc-speculative-annotations/issues/65

One thing I can try and refine is to allow the type tool to type on top of existing non-text objects. But if hovering over a "type" object, don't allow a new typing to happen?

Or, I just pull back the behavior I implemented over the weekend and don't allow typing on top of any previously added objects (which is what I've seen in a few comparable annotation apps).

[CourtneyMcClellan]

Sorry I missed the question. Jaime and I think to pull back the behavior you implemented this weekend. I think this will make the curator annotations much easier.

A further question: The motivations for this layering is the use case: typing over a thought bubble. Is there a way to distinguish layering text with text or text with stamp? Does the canvas see them as the same thing?

On Wed, May 5, 2021 at 3:45 PM Adam J. Arling @.***> wrote:

@CourtneyMcClellan https://github.com/CourtneyMcClellan So this is related either in part or in full to this issue, which was at the top of the "To do" column over the weekend. I pitched a question on it, but never heard back.

65 https://github.com/adamjarling/loc-speculative-annotations/issues/65

One thing I can try and refine is to allow the type tool to type on top of existing non-text objects. But if hovering over a "type" object, don't allow a new typing to happen?

Or, I just pull back the behavior I implemented over the weekend and don't allow typing on top of any previously added objects (which is what I've seen in a few comparable annotation apps).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamjarling/loc-speculative-annotations/issues/78#issuecomment-832960340, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOHXDCBDKWMRLJXG6WSSCLTMGN6BANCNFSM42WQ5S7A .

[adamjarling]

Ah, gotcha. I can double check, but I believe we can only distinguish between the type of FabricJS object. Ie. an "ellipse", "square", "text", "line", etc. Speech bubbles would fall under the category of "SVG" or "image" I think, so trying to build logic into typing on top of something, would include Stamps and Speech bubbles. I can test this out and let you know what the possibilities are.

[CourtneyMcClellan]

Ok, cool. That would be awesome, thank you.

On Wed, May 5, 2021 at 5:18 PM Adam J. Arling @.***> wrote:

Ah, gotcha. I can double check, but I believe we can only distinguish between the type of FabricJS object. Ie. an "ellipse", "square", "text", "line", etc. Speech bubbles would fall under the category of "SVG" or "image" I think, so trying to build logic into typing on top of something, would include Stamps and Speech bubbles. I can test this out and let you know what the possibilities are.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamjarling/loc-speculative-annotations/issues/78#issuecomment-833013745, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOHXDBRJ5K5QUNOXATMSG3TMGYZ3ANCNFSM42WQ5S7A .

[adamjarling]

@CourtneyMcClellan Playing around with this event behavior this morning and trying to wrap my head around things. So is the motivation here to type over a StampQuestion (the new images), or to type on top of an existing Stamp, which happens to be a Speech Bubble type Stamp shape?

[CourtneyMcClellan]

Type on top of an existing stamp like a thought bubble.

On Thu, May 6, 2021 at 9:14 AM Adam J. Arling @.***> wrote:

@CourtneyMcClellan https://github.com/CourtneyMcClellan Playing around with this event behavior this morning and trying to wrap my head around things. So is the motivation here to type over a StampQuestion (the new images), or to type on top of an existing Stamp, which happens to be a Speech Bubble type Stamp shape?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamjarling/loc-speculative-annotations/issues/78#issuecomment-833512570, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOHXDEJR6JZT5VBUC4CRRDTMKI2LANCNFSM42WQ5S7A .

[adamjarling]

@CourtneyMcClellan Gotcha. Well, seems like I can identify certain objects (like a Stamp, or the new Speech Bubble Stamps), which will allow text to be typed upon. If this functionality works out, would the new Speech Bubble Stamps go away, and we just use existing Stamp shapes that are speech bubbles?

[adamjarling]

[CourtneyMcClellan]

No, the quick questions would stay. The goal would be that typing on the stamp while removing the need to layer other items. We had difficulty using the text tool because it was hard to pick up the box because the cursor kept starting a new text.

On Thu, May 6, 2021 at 9:43 AM Adam J. Arling @.***> wrote:

@CourtneyMcClellan https://github.com/CourtneyMcClellan Gotcha. Well, seems like I can identify certain objects (like a Stamp, or the new Speech Bubble Stamps), which will allow text to be typed upon. If this functionality works out, would the new Speech Bubble Stamps go away, and we just use existing Stamp shapes that are speech bubbles?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamjarling/loc-speculative-annotations/issues/78#issuecomment-833533462, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOHXDFJZXNAHQTB5RSK6YTTMKMGRANCNFSM42WQ5S7A .

[adamjarling]

Ok. For now I'm pushing up changes to staging which revert the previous update allowing text to be typed on top of any object on the canvas. So for the time being, a user cannot type on top of an existing object, until we get the functionality ironed out.

[CourtneyMcClellan]

Great, that makes sense.

On Thu, May 6, 2021 at 9:57 AM Adam J. Arling @.***> wrote:

Ok. For now I'm pushing up changes to staging which revert the previous update allowing text to be typed on top of any object on the canvas. So for the time being, a user cannot type on top of an existing object, until we get the functionality ironed out.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamjarling/loc-speculative-annotations/issues/78#issuecomment-833544740, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOHXDGQZ3CP3ZEULY45KITTMKN43ANCNFSM42WQ5S7A .

[jessvu]

@CourtneyMcClellan @jaimemears wondering what your thoughts are on making the ability to wrap text a higher priority issue. I noticed from user-testing that users tend to write a lot while annotating so allowing the ability to wrap text would improve their experience and allow them to annotate faster. I see this feature as particularly useful to those trying to fit several lines of text inside of a stamp area, e.g. writing dialogue inside of a speech bubble. Here is an example of what that functionality might look like: https://docs.google.com/presentation/d/1kOKl3iC7_b7VOVp64xXCJtnPoAcv90rll2J5jpHoA5s/edit#slide=id.gcede5aee13_0_43

[adamjarling]

Hey @jessvu I actually just pushed up some changes yesterday for typing in a bounding box. You can see comments here:

https://github.com/adamjarling/loc-speculative-annotations/issues/66

Also, if you're curious as to what I'm working on as we enter the home stretch of prioritizing given my somewhat limited balance of time, I'm trying to keep the project board accurate with issues I'm moving through:

https://github.com/adamjarling/loc-speculative-annotations/projects/1

[jaimemears]

@CourtneyMcClellan is the text tool good now? It seems greatly greatly improved with @adamjarling latest changes. If so, I will close this issue.

[jaimemears]

this is great. closing.