search

adamjarling / loc-speculative-annotations

Library of Congress Labs, Artist in Residency program project. Speculative Annotation.
https://nervous-gates-006218.netlify.app/
15 stars 0 forks source link

Quick questions stamp #88

Closed jaimemears closed 3 years ago

jaimemears commented 3 years ago

Quick question stamps are available seperately in the toolbar at the top. We need an icon for this and the stamps

adamjarling commented 3 years ago

@CourtneyMcClellan @jessvu Possible to get a visual of what this will look like?

CourtneyMcClellan commented 3 years ago

Yes, Jess is working on the interface, I am working on the stamps. The stamps should look something like this, and function exactly like the stamps, but just have its own different icon.

On Sat, Apr 17, 2021 at 10:12 AM Adam J. Arling @.***> wrote:

@CourtneyMcClellan https://github.com/CourtneyMcClellan @jessvu https://github.com/jessvu Possible to get a visual of what this will look like?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamjarling/loc-speculative-annotations/issues/88#issuecomment-821828908, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOHXDBRY5UTQPCR7GSUXXDTJGJKNANCNFSM43B6VUIA .

jessvu commented 3 years ago

image this is annotated in Figma

CourtneyMcClellan commented 3 years ago

Olivia is working on these and will post this weekend (4/24/21). If there are specific formatting concerns (SVG vs PNG) and labeling colors (I ask because we went back and forth on this last time and I want to make it as easy as possible) please let us know.

jessvu commented 3 years ago

@CourtneyMcClellan my only suggestion is to be mindful of color contrast to ensure that the questions are readable. If you are putting any text against a white background, I would use pink or navy colored text.

adamjarling commented 3 years ago

Ok, a few questions on my end...

I believe the most flexible implementation of this would be:

Maybe we do a quick prototype with one transparent SVG speech bubble file to see how it plays out?

CourtneyMcClellan commented 3 years ago

Ok, a few questions on my end...

I believe the most flexible implementation of this would be:

Maybe we do a quick prototype with one transparent SVG speech bubble file to see how it plays out?

They won't be transparent

I'm CCing Olivia on this since she is working on it today. Olivia, feel free to throw out questions. All bubbles will be the same color and stick to ones that don't have a clear center if aAdam prefers it.

On Sat, Apr 24, 2021 at 7:29 AM Adam J. Arling @.***> wrote:

Ok, a few questions on my end...

  • Will the speech bubble only be one color, or should the speech bubble respect active color (like regular Stamp)?
  • Is the dark bubble background in which text rests (referring to image above), transparent, or does this need to be black?

I believe the most flexible implementation of this would be:

Maybe we do a quick prototype with one transparent SVG speech bubble file to see how it plays out?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamjarling/loc-speculative-annotations/issues/88#issuecomment-826078793, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOHXDGGI3H44UYT63WKDODTKKTP7ANCNFSM43B6VUIA .

adamjarling commented 3 years ago

Great, so if the speech bubble files are just one color (for example blue), and won't change colors based on active color, then this makes things much easier.

Olivia, I think creating these speech bubble images as SVG files will work out best. If you want to prep a sample image or 2, I can plug it in and make sure all works as expected.

CourtneyMcClellan commented 3 years ago

@adamjarling A quick question test stamp: https://drive.google.com/drive/folders/1_-63lFjra391bBAVWYHCnx2ES11u3bNT?usp=sharing

adamjarling commented 3 years ago

@CourtneyMcClellan I'm having problems opening that file in the app, and even in Adobe Illustrator.

image

adamjarling commented 3 years ago

Just pushed up placeholder stamp artwork, but the UX should be mostly in place.

image

CourtneyMcClellan commented 3 years ago

Great!

On Tue, Apr 27, 2021 at 9:27 AM Adam J. Arling @.***> wrote:

Just pushed up placeholder stamp artwork, but the UX should be mostly in place.

[image: image] https://user-images.githubusercontent.com/3020266/116249359-5ae39600-a732-11eb-9736-14a25d5e6caa.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamjarling/loc-speculative-annotations/issues/88#issuecomment-827605814, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOHXDDV2QYPVQKMTU7242DTK23VPANCNFSM43B6VUIA .

CourtneyMcClellan commented 3 years ago

Olivia updated the files, there is a new SVG as well as a PNG. Let me know if either work

https://drive.google.com/drive/folders/1_-63lFjra391bBAVWYHCnx2ES11u3bNT?usp=sharing

adamjarling commented 3 years ago

@CourtneyMcClellan Here's the error I'm still getting on the SVG file. I think it's how she's exporting the file. There should be an option in Illustrator to like trace the paths, and then you'd just export the selected paths.... something like that.

image

The PNG file might work too. I can try and plug that in later this afternoon and will report back.

CourtneyMcClellan commented 3 years ago

https://drive.google.com/drive/folders/1_-63lFjra391bBAVWYHCnx2ES11u3bNT?usp=sharing

@adamjarling Olivia has updated the files. I am able to see the SVG files that are titled embedded. Can you access them? If they look good, I will have her upload the rest.

adamjarling commented 3 years ago

Yea, looking good here.

image

CourtneyMcClellan commented 3 years ago

quick question stamps to be uploaded: https://drive.google.com/drive/folders/13JMfUgzrdoIbpXNWzCcoqwr16ulQM7XD?usp=sharing

adamjarling commented 3 years ago

@CourtneyMcClellan There's something a little off on the latest SVG files pushed up. I'll check and see if using PNG files is possible instead of SVG if they continue to be troublesome.

image

image

adamjarling commented 3 years ago

Hey @CourtneyMcClellan So in playing around with this, seems PNG files might be a more straightforward solution at this point. I'm testing with a sample PNG file now you previously posted (stamps-02.png), and everything seems to work. Note we won't be able to adjust the fill color (ie. from light blue to any currently selected color in the app), but that doesn't seem to be a current requirement anyhow.

image

image

CourtneyMcClellan commented 3 years ago

Quick Questions in PNG form: https://drive.google.com/drive/folders/1aruO7wt7Cx1hakJ5RNHDIGPJwQk2Y46y?usp=sharing

adamjarling commented 3 years ago

New quick question stamps pulled in as PNG files and implemented.

CourtneyMcClellan commented 3 years ago

@adamjarling I am having trouble using the quick questions, I can select in the panel, but then I can not get out of the selection panel and it does not drop on the canvas

adamjarling commented 3 years ago

@CourtneyMcClellan Ah, this is a bug that started happening when I updated the UI framework we're using 2 days ago. I noticed the bug in Select a Work and fixed it, but will apply the same fix here and to any other modals we're using as well. Good catch.

adamjarling commented 3 years ago

Now updated.

image