search

adamjezek98 / ubnt-etherlighting

113 stars 4 forks source link

Reading Credentials from Environment Variables #1

Open hamkido opened 6 months ago

hamkido commented 6 months ago

When I was trying to run the code, I discovered that the current implementation of Etherlighting defaults to using the username of the execution computer for SSH login, as shown in the referenced code. https://github.com/adamjezek98/ubnt-etherlighting/blob/733950b3bd6337be203dbf39725e28abd705bd8e/etherlight.py#L36 This design may cause login failures if the SSH username is different from the local system username.

hamkido commented 6 months ago

I made some simple changes that should be of some help to anyone who wants to use the username and password from the env https://github.com/adamjezek98/ubnt-etherlighting/pull/2