search

adamjford / 30kAPM

CMPUT 350 Group Project
GNU General Public License v3.0
1 stars 1 forks source link

Refine marine #13

Closed xiasuke closed 9 years ago

xiasuke commented 9 years ago

Marines mirco controller should be fixed now.

5

adamjford commented 9 years ago

I made a few additional changes to getTerranBuildOrderGoal(). I removed some unneeded cruft from the original cde and made Medics actually build. However, it's definitely still going to need work in #8. I'm going to detail the problems I discovered in that issue.

adamjford commented 9 years ago

Could someone take a look at my changes and merge this pull request in if satisfied? Note that you can add ?w=1 to the end of a pull request URL to ignore whitespace changes.

xiasuke commented 9 years ago

I took a look at it and it had trouble figuring out what to build. I tried to fix it but it seems like it is still a problem. Other than that it seems to work great most of the time.

adamjford commented 9 years ago

Could someone other than me and Queenie please take a look at the changes here and merge it in if acceptable?

@grepme @alexgfh

xiasuke commented 9 years ago

Ok, I did some changes, now just need someone else to check and merge this. Oh and I'm not sure when the marines should use the stim pack. Right now they are only set to use it on like 3 certain units I believe. So feel free to change it to whenever you think they should use it. It'll be in the RangedManager.cpp

grepme commented 9 years ago

I posted some related comments here: https://github.com/adamjford/30kAPM/issues/5

I will also look into this right now and prioritize it.