search

adamjimenez / shiftedit

ShiftEdit IDE
Other
82 stars 18 forks source link

Terminal bug #321

Closed shanemarsh28 closed 6 years ago

shanemarsh28 commented 6 years ago

Seems the Terminal is not filling the whole window and when you run something that auto updates (htop), ShiftEdit turns into the Matrix ...

image

adamjimenez commented 6 years ago

Resizing the window should trigger a terminal resize..

On Thu, 9 Aug 2018 at 09:58, Shane Marsh notifications@github.com wrote:

Seems the Terminal is not filling the whole window and when you run something that auto updates (htop), ShiftEdit turns into the Matrix ...

[image: image] https://user-images.githubusercontent.com/16979556/43888915-bc96f0c6-9bba-11e8-8360-3efad53d3253.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adamjimenez/shiftedit/issues/321, or mute the thread https://github.com/notifications/unsubscribe-auth/AAi_CFTjDh4rqGALspqENvt-i4OilCgiks5uO_mwgaJpZM4V1ThS .

-- Best regards, Adam Jimenez

shanemarsh28 commented 6 years ago

Not anymore ;( The div class .xterm-screen and all the structures below it all have a fixed width of 720px.

adamjimenez commented 6 years ago

WFM, are there any errors in the js console?

On Thu, 9 Aug 2018 at 10:40, Shane Marsh notifications@github.com wrote:

Not anymore ;( The div class .xterm-screen and all the structures below it all have a fixed width of 720px.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/adamjimenez/shiftedit/issues/321#issuecomment-411699973, or mute the thread https://github.com/notifications/unsubscribe-auth/AAi_CM1x9m6XESEVOqhEX3ToEv8Ml7Yfks5uPAOHgaJpZM4V1ThS .

-- Best regards, Adam Jimenez

shanemarsh28 commented 6 years ago

Ahh. I didn't look there. Yes ...

shiftedit-19.0.50.js:667 Uncaught TypeError: Cannot read property 'width' of undefined at C (shiftedit-19.0.50.js:667) at HTMLLIElement. (shiftedit-19.0.50.js:667) at Function.each (shiftedit-19.0.50.js:630) at we.fn.init.each (shiftedit-19.0.50.js:630) at shiftedit-19.0.50.js:667

adamjimenez commented 6 years ago

Are there steps to reproduce this issue?

On Thu, 9 Aug 2018 at 10:46, Shane Marsh notifications@github.com wrote:

Ahh. I didn't look there. Yes ...

shiftedit-19.0.50.js:667 Uncaught TypeError: Cannot read property 'width' of undefined at C (shiftedit-19.0.50.js:667) at HTMLLIElement. (shiftedit-19.0.50.js:667) at Function.each (shiftedit-19.0.50.js:630) at we.fn.init.each (shiftedit-19.0.50.js:630) at shiftedit-19.0.50.js:667

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/adamjimenez/shiftedit/issues/321#issuecomment-411701620, or mute the thread https://github.com/notifications/unsubscribe-auth/AAi_CKSepv1wqtAFIwa7RqWJWUEbWgcoks5uPATngaJpZM4V1ThS .

-- Best regards, Adam Jimenez

shanemarsh28 commented 6 years ago

Only the usual: Open Shift Edit -> Open terminal -> Connect to a server.

Then the Console error appears. I have hard refreshed to see if that clears the issue but sadly not.

shanemarsh28 commented 6 years ago

Oh I should mention I'm running Windows 10 and Chrome: Version 68.0.3440.84 (Official Build) (64-bit)

adamjimenez commented 6 years ago

Ok, I'm seeing it now - it seems to be a new feature in Chrome 68!

On Thu, 9 Aug 2018 at 11:20, Shane Marsh notifications@github.com wrote:

Oh I should mention I'm running Windows 10 and Chrome: Version 68.0.3440.84 (Official Build) (64-bit)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/adamjimenez/shiftedit/issues/321#issuecomment-411710475, or mute the thread https://github.com/notifications/unsubscribe-auth/AAi_CFaPgkcqzfiZ9QAmuT4zGEEpehvYks5uPAzqgaJpZM4V1ThS .

-- Best regards, Adam Jimenez

adamjimenez commented 6 years ago

fix pushed to dev: 19.0.51

On Thu, 9 Aug 2018 at 11:24, Adam Jimenez adam.jimenez@gmail.com wrote:

Ok, I'm seeing it now - it seems to be a new feature in Chrome 68!

On Thu, 9 Aug 2018 at 11:20, Shane Marsh notifications@github.com wrote:

Oh I should mention I'm running Windows 10 and Chrome: Version 68.0.3440.84 (Official Build) (64-bit)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/adamjimenez/shiftedit/issues/321#issuecomment-411710475, or mute the thread https://github.com/notifications/unsubscribe-auth/AAi_CFaPgkcqzfiZ9QAmuT4zGEEpehvYks5uPAzqgaJpZM4V1ThS .

-- Best regards, Adam Jimenez

-- Best regards, Adam Jimenez

shanemarsh28 commented 6 years ago

Perfect thanks Adam 👍