search

adamjimenez / shiftedit

ShiftEdit IDE
Other
82 stars 18 forks source link

MINOR SUGGESTION: Consider moving "Unsaved Changes" dot to left side of tab. #365

Closed mpmw closed 4 years ago

mpmw commented 4 years ago

As shown by the attached image, since file names are flush-left and the unsaved changes symbol is flush right, a quick glance would have you believe that the second tab has unsaved changes.

Screenshot 2020-01-17 at 9 20 23 AM

adamjimenez commented 4 years ago

I like where it is because it doesn't take extra real-estate or change the indentation. What I will do is change the tab widths so that they flex to the amount of text. This will help by keeping the symbol closer to the text.

On Fri, 17 Jan 2020 at 17:27, mpmw notifications@github.com wrote:

As shown by the attached image, since file names are flush-left and the unsaved changes symbol is flush right, a quick glance would have you believe that the second tab has unsaved changes.

[image: Screenshot 2020-01-17 at 9 20 23 AM] https://user-images.githubusercontent.com/19599626/72632390-08021880-390b-11ea-8e39-c553bd0d9a25.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adamjimenez/shiftedit/issues/365?email_source=notifications&email_token=AAEL6CAIFGEYBGY3CUBLRWDQ6HTAVA5CNFSM4KILUKQKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IG73BWQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEL6CEJI4FVSPLOQYZNJMLQ6HTAVANCNFSM4KILUKQA .

-- Best regards, Adam Jimenez

mpmw commented 4 years ago

Great solution. Works perfectly.