adamjmcgrath / react-native-simple-auth

OAuth login for React Native
MIT License
669 stars 104 forks source link

Google authentication dialog box is lost #64

Open ozsirma opened 7 years ago

ozsirma commented 7 years ago

vizzler

I have the problem.After several seconds then redirect google. How can I solve this problem ?

adamjmcgrath commented 7 years ago

It looks like deep links are not set up correctly on your application.

Make sure you follow the instructions in: https://github.com/adamjmcgrath/react-native-simple-auth#install Which point to: https://facebook.github.io/react-native/docs/linking-libraries-ios.html#manual-linking

And the instructions on how to set up the Google Provider: https://github.com/adamjmcgrath/react-native-simple-auth#google Which point to instructions on how to set up urls schemes in iOS here https://dev.twitter.com/cards/mobile/url-schemes

filiphosko commented 7 years ago

The same happens in the sample app https://github.com/adamjmcgrath/ReactNativeSimpleAuthExample (try to run it in an iOS simulator). I think deep linking is set up correctly since when I paste my credentials there I can get all the data from the callback and don't have any (noticeable) errors, only this "timeout" occurs.

ozsirma commented 7 years ago

Linking is true because Facebook login is working. Only google login redirect after several seconds and then dialog box is lost.

filiphosko commented 7 years ago

You have this "issue" also in react-native-oauth package. I don't know if there is a possibility to make the timeout longer or get rid of it completely, at least what would be great is to handle the "dismissal" so we could return automatically to our app and not stay in the browser. But I wonder if implementing Universal Links (somehow) would solve the issue since according to this it seems to me that the alert only shows when we use standard deep linking (more here).

adamjmcgrath commented 7 years ago

Ah ok, so this happens when you don't accept the 'Open this page in "VizzleR"' dialog - I didn't get that from the screencast.

Yes, Universal Links might be a solution for that - but it would make the setup even more complicated. I'm also looking at a solution that uses WebView and onShouldStartLoadWithRequest. The benefit for this would be that the setup would be easier for iOS and we could offer providers that don't accept custom schemes in the redirect_uri (like instagram).

Am trying to workaround errors I'm getting in the WebView at the moment, so that is slightly blocked by https://github.com/facebook/react-native/pull/12482

ozsirma commented 7 years ago

any progress ? @adamjmcgrath

buskerone commented 7 years ago

I think this issue has high priority. I was trying to find a solution but without any success.

MaxInMoon commented 6 years ago

Did someone find a solution?

anwargul0x commented 5 years ago

@adamjmcgrath .... can you please help .. i am facing this issue in my project Package.json

"dependencies": { "@ptomasroos/react-native-multi-slider": "^1.0.0", "axios": "^0.18.0", "react": "16.8.3", "react-native": "0.59.2", "react-native-animatable": "^1.3.2", "react-native-confirmation-code-input": "^1.0.4", "react-native-elements": "^1.1.0", "react-native-elevated-view": "0.0.6", "react-native-fbsdk": "^0.8.0", "react-native-gesture-handler": "^1.1.0", "react-native-picker-select": "^6.1.0", "react-native-ratings": "^6.3.1", "react-native-simple-auth": "^2.4.0", "react-native-splash-screen": "^3.2.0", "react-native-swiper": "^1.5.14", "react-native-vector-icons": "^6.4.2", "react-navigation": "^3.5.1" }, "devDependencies": { "@babel/core": "^7.4.0", "@babel/runtime": "^7.4.2", "@react-native-community/eslint-config": "^0.0.3", "babel-jest": "^24.5.0", "eslint": "^5.15.3", "jest": "^24.5.0", "metro-react-native-babel-preset": "^0.53.1", "react-test-renderer": "16.8.3" }, "jest": { "preset": "react-native" }, "rnpm": { "assets": [ "./src/assets/fonts/" ] } }

React-Native Info info React Native Environment Info: System: OS: Windows 8.1 CPU: (4) x64 Intel(R) Core(TM) i5-3470S CPU @ 2.90GHz Memory: 8.03 GB / 11.89 GB Binaries: npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD IDEs: Android Studio: Version 3.3.0.0 AI-182.5107.16.33.5314842