adamjstewart / fiscalyear

:calendar: Utilities for managing the fiscal calendar
MIT License
52 stars 13 forks source link

Removing warnings filter changes from package #22

Closed further-reading closed 3 years ago

further-reading commented 3 years ago

The code warnings.simplefilter("default") expands what warnings are shown and can cause warnings and errors which are normally not expected in other packages to show. In addition, depending on the import order this can override changes to the warnings filter made by the user. I think it would be better to remove this from the package to prevent issues caused by users receiving unexpected warnings/errors.