search

adamjstewart / fiscalyear

:calendar: Utilities for managing the fiscal calendar
MIT License
52 stars 13 forks source link

Add syntactic sugar for getting the current Fiscal{Year,Quarter}. #4

Closed pmav99 closed 5 years ago

pmav99 commented 6 years ago

Fixes #2

I had to add pytest-mock in the dependencies.

I also thought that it would be better if a native speaker wrote the docs.

Anyway, check it out and let me know of any remarks.

codecov-io commented 6 years ago

Codecov Report

Merging #4 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         254    262    +8     
=====================================
+ Hits          254    262    +8
Impacted Files Coverage Δ
fiscalyear.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3bf1e0...7655cae. Read the comment docs.

adamjstewart commented 6 years ago

Thanks! I'll try to get a chance to review this and your other PR sometime in the next week. I have exams coming up (student life...) so I apologize if I get side-tracked. Ping me if I don't respond in a week.

pmav99 commented 6 years ago

ping!

adamjstewart commented 5 years ago

Ping @pmav99. Aside from my last 2 requested changes, I think this PR is ready to go!

adamjstewart commented 5 years ago

Thanks for the PR! I'll play around with the docs and do some testing and try to put out a new release by the end of the week. Sorry it took so long to get this merged!