Closed ZaidQureshi closed 6 years ago
Fixed all of your tests for the modifications of the ast. Also removed the semicolon token from lexer, parser, and their tests. Regarding stuff from evaluator.ml, things are only "easier" if nothing is implemented and things don't work (which isn't our case). Also, restricting the type that can be passed into string_of_atom causes warnings. In fact to truly solve this issue we would need to modify our AST slightly but that isn't necessary.
Could you add docstrings to every function you wrote? That would help greatly in understanding what it is supposed to do.
Yes, also the report should help. If/when you are back in town maybe we should meet up so I can explain it.
This makes a fundamental change to our ast. Now, a Clause has a head and a body where the body is a list of exps. The list represents a conjunction between all the exps in the list. Similarly a Query is a list of exps where the lsit represents a conjunction between all the exps in the list. This is to simplify the evaluation. Disjunction has been removed. I didn't modify any of the test files.