Bug in Myfont.cpp (Myfont:Banner) overrights LedSign::SetBrightness() settings.

[GoogleCodeExporter]

What steps will reproduce the problem?
1. set lolshield with "LedSign::Init(GRAYSCALE);"
2. Send text to LoLshield via Myfont::Banner(tLen,Text);
3. LedSign::SetBrightness(); Is ignored due to draw code in Myfont.cpp

What is the expected output? What do you see instead?
Expected: Variable led shades due to LedSign::SetBrightness(); initialization 
within code. Instead: Myfont:Banner uses the below to draw the text. "tmps" 
sets the brightness when the (GRAYSCALE) option is used.
[code] LedSign::Set(xval+i, j+1, tmps); /*write it*/ [/code]

What version of the product are you using? On what operating system?
LolShield v1.5, v0.23 Library

Original issue reported on code.google.com by malle...@gmail.com on 3 Mar 2012 at 11:35

[GoogleCodeExporter]

Here's a patch that adds grayscale support to the Myfont::Draw and 
Myfont::Banner methods.

Original comment by marcko...@gmail.com on 9 Dec 2012 at 3:16

Attachments:

• include_grayscale_support_in_Myfont.patch

[GoogleCodeExporter]

excellent thank you

Original comment by malle...@gmail.com on 15 Dec 2012 at 2:30

[GoogleCodeExporter]

While the patch works, took me a little to work it out, it doesn't utilize the 
"LedSign::SetBrightness();" option already used in the code.

Original comment by malle...@gmail.com on 22 Dec 2012 at 5:15

[GoogleCodeExporter]

was fixed long ago (revision 2) in the repository

Original comment by r...@ihack.net on 20 Aug 2013 at 6:26

• Changed state: Fixed