search

adamkarvonen / SAEBench

7 stars 10 forks source link

Rename utils to avoid name conflict #5

Closed koayon closed 1 month ago

canrager commented 1 month ago

thanks! Is the main intent of this PR to rename the utils folder to sae_bench_utils? If yes, would you be able to make a PR with only import lines and filenames changed?

I'm not sure if there's some other fuctionality contained in this PR. Could you please use nbstripout --install to make sure you're not pushing the cell outputs in notebooks?

koayon commented 1 month ago

Hey! Yes that's the only functional change.

The other changes that have been made are purely cosmetic - the imports have been ordered by isort and the formatter has made some readability changes.

Ahhh, nbstripout looks super useful! Agree it's good to not push the Jupyter cell changes, I'll revert the notebook parts to only change the import name part - thanks for the rec 🙏

koayon commented 1 month ago

I don't think I saw any formatter in the repo but if you have an opinionated formatter that you like then we should maybe use those settings instead 👌

canrager commented 1 month ago

Thanks! I'm sorry, I'm not aware of a clean way to automatically apply NB stripout, Claude's suggestions seem like some overhead. Are you aware of best practices?