search

adamkewley / jobson

A platform for transforming command-line applications into a job service.
Apache License 2.0
256 stars 20 forks source link

Feature request: able to show an image on a job submission page. #83

Closed herofmm closed 2 years ago

herofmm commented 3 years ago

Dear Adam,

First, thank you for making this wonderful project and share it freely. We are currently developing a website using this tool, and I would like to request a feature addition as follow.

Would it be possible to show an image on the job submission page. Currently, we can add texts. But, it will be always better to show a diagram or an image for the target problem.

Thank you. Donghyuk Shin

p.s. below is our deployed website for chemical kinetics calculation. https://flame.kaist.ac.kr

adamkewley commented 3 years ago

Hi @herofmm

I'm very happy that you have used it in chemistry! I used to study chemistry in a past life :D

Adding that feature shouldn't be too hard. It will likely require adding an headerImage: field into spec.yml, followed by adding a "headerImage": { "filename": "file.png", "data": "base64str" } field onto the JSON that base64-encodes the image somehow.

However, I can't commit to doing it right away. I'm currently juggling several large projects and don't really have time to focus on Jobson so often. I'll try and hammer it out one evening/weekend but, again, I can't say "yep, it will be done by next week" because many work/life commitments pop up recently.

If anyone else reading this wants to give it a whirl, then be my guest. Implementation steps will be:

tartics commented 3 years ago

Dear @adamkewley

First, thank you for the great project! I'm one of the people who developing the website for chemical kinetics calculation.

As @herofmm mentioned earlier, I'm trying to put an image on the job submission page in the way you said. I added headerImage: into spec.yml and put "headerImage": { "filename": "file.png", "data": "base64str" } in share/java/jobson-swagger.json file. However, it didn't work.

So, I wonder if jobson-swagger.json is JSON. If right, where I have to put "headerImage":?

Thanks a lot.

adamkewley commented 3 years ago

The headerImage field is not yet implemented in jobson, so this will not work yet. I need to spend some time--which I don't currently have very much of--to implement the feature for you!

Adam

On Thu, 9 Sept 2021 at 12:25, tartics @.***> wrote:

Dear @adamkewley https://github.com/adamkewley

First, thank you for the great project! I'm one of the people who developing a website for chemical kinetics calculation.

I'm trying to put the image on the job summation page in the way you said it. I added headerImage: into spec.yml and put "headerImage": { "filename": "file.png", "data": "base64str" } in share/java/jobson-swagger.json file. However, it didn't work.

So, I wonder if jobson-swagger.json is JSON. If right, where I have to put "headerImage":?

Thanks a lot.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamkewley/jobson/issues/83#issuecomment-915961126, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEC5SULNNSSRGFVEUFF2I3UBCDQRANCNFSM5DRSOTOA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

adamkewley commented 2 years ago

Closed because, although it's a great feature idea, there is no active development time to implement this (I'm working on several other projects)