Open Suzii opened 5 years ago
Hi @Suzii, thanks!
Do you please have a link to some presentation/code in regard to the dependency injection? We probably missed the lecture and I would like to know how it looks like :)
Sure, here is the lecture and I believe you can find some code here.
Now that I read my previous comment, I feel like I have mostly criticized in my final evaluation. However, I do not think you app or it's code was bad, on the contrary, I liked it and I think that you did a great job with structuring your code put great effort into writing all those tests. So thanks 😉 (I was a bit tired, when I wrote it yesterday 😆 )
Status ✔️(zapocet comming soon)
A few lines about code/design:
/\S/.test(name)
and then a comment explaining what the regex is actually doing. Could have been so much better if it was encapsulated within a well-named validation function reused everywhere :)state.userApp.users.byId.toList()
in container :( memoization is crying.