Final evaluation

[Suzii]

Status ✔️(zapocet comming soon)

• Thanks for readme & prepared users
• UI is a bit buggy, the text overflows on smaller screens. On every second character I type a scrollbar appears which causes the whole view jump on every keystroke (I use Chrome). And as you probably know, there are bit too many borders and large paddings, too much scrolling, but that has nothing to do with the functionality, of course :)
• You could have done the search case insensitive (very low effort but a huge improvement)
• The app does not reload the messages so it does not really serve as instant messaging.

A few lines about code/design:

• Why not using async/await everywhere? :)
• I like the generic service wrappers and the api/ folder. You could have use the generics when calling PV247Service instead of type casting the result within specific service via "as XY".
• String interpolation would have looked a bit nicer than all those string concatenations to build a URL.
• Why not using combineReducers? :(
• Not all interfaces use readonly.
• Isn't the folder Screen/ and its components slightly redundant? :D
• You have so many check like this one in the code /\S/.test(name) and then a comment explaining what the regex is actually doing. Could have been so much better if it was encapsulated within a well-named validation function reused everywhere :)
• state.userApp.users.byId.toList() in container :( memoization is crying.
• Many, many test, thumbs up for that, although it's a pity you did not do the Dependency Injection as explained in the Lectures.

[adamkral12]

Hi @Suzii, thanks!

Do you please have a link to some presentation/code in regard to the dependency injection? We probably missed the lecture and I would like to know how it looks like :)

[Suzii]

Sure, here is the lecture and I believe you can find some code here.

Now that I read my previous comment, I feel like I have mostly criticized in my final evaluation. However, I do not think you app or it's code was bad, on the contrary, I liked it and I think that you did a great job with structuring your code put great effort into writing all those tests. So thanks 😉 (I was a bit tired, when I wrote it yesterday 😆 )