Unvalidated date time in books publish date

adamkrogh / goodreads-dotnet

:books: Goodreads .NET API Client Library

MIT License

51 stars 15 forks source link

Unvalidated date time in books publish date #14

Closed mmmmmmmmm2 closed 6 years ago

mmmmmmmmm2 commented 6 years ago

It looks like that Goodreads doesn't validate books' publish date information as you can see in the below book, publish year is 20176. https://www.goodreads.com/book/show/35222701-net-microservices

As we parse the publish date in "ElementAsMultiDateField" method, the 20176 can't be parsed to a valid .NET DateTime and an exception would be thrown.

VladimirRybalko commented 6 years ago

This is true. I even can't imagine that Goodreads allows to fill out the publication field in that manner. I'm a bit confused... In any case I'll fix it soon.

VladimirRybalko commented 6 years ago

I've fixed it. Feel free to download an upgraded version from nuget. Thank you for reporting the issue @m-karimi