search

adamkrogh / goodreads-dotnet

:books: Goodreads .NET API Client Library
MIT License
51 stars 15 forks source link

Support .NET Standard 2.0 #7

Closed Inrego closed 7 years ago

Inrego commented 7 years ago

Once RestSharp supports .NET Standard, I think this library should be updated to do so aswell. Issue about the topic on RestSharp: https://github.com/restsharp/RestSharp/issues/992

VladimirRybalko commented 7 years ago

Hi @Inrego. It's a good idea. I'm going to add it as soon as possible.

@adamkrogh what do you think about it?

I assume I could migrate all library code to .NET Standard 2.0 without any problems. However I have some doubts about our test project. I am not sure how new test engine will work in Travis CI. Might be you will should reconfigure some settings after migration.

VladimirRybalko commented 7 years ago

I've migrated solution to .NET Standard 2.0.

@adamkrogh Could you please reconfigure CI server to work with VS 2017 and .NET Core 2.0 XUnit tests.

adamkrogh commented 7 years ago

@VladimirRybalko I still can't believe all the awesome work you've been doing. I've recently changed jobs and moved to a new city so I've kind of been out of touch lately. I'll try and get everything straightened out on the CI this weekend and I'll send you a message about maybe getting the next release together soon. Thanks again!